adding iterators #83
adding iterators #83
Conversation
dlockhart
force-pushed
the
dlockhart/iterators
branch
from
c6dba71
to
9be7ca4
Compare
| grid-template-columns: 300px auto; | ||
| grid-template-columns: 275px auto; | ||
| height: 100vh; | ||
| overflow: hidden; |
There was a problem hiding this comment.
Was able to simplify the CSS grid stuff a bit.
| padding-top: 20px; | ||
| } | ||
| .list-file-title { | ||
| padding-bottom: 20px; |
There was a problem hiding this comment.
The test list now uses similar spacing and separators as the results:
| `; | ||
| } | ||
| _handleBackClick() { | ||
| this._updateSearchParams({ file: undefined, test: undefined }); | ||
| } |
There was a problem hiding this comment.
This and _handleListTestClick didn't end up being necessary due to the <a href> doing the same thing -- it was actually firing things twice.
| @@ -312,6 +306,7 @@ class App extends LitElement { | |||
| return renderTabButtons('browser results', tabs, index => { | |||
| this._selectedBrowserIndex = index; | |||
| this.shadowRoot.querySelector('.tab-panels').scrollTo(0, 0); | |||
| this.requestUpdate(); | |||
There was a problem hiding this comment.
_selectedBrowserIndex isn't a reactive state property anymore since we modify it ourselves. But in this case they've selected a new tab so we force a re-render.
| this._selectedBrowserIndex = Math.max( | ||
| browsers.findIndex((b) => browserResults.get(b.name) < tests.length), | ||
| 0 | ||
| ); |
There was a problem hiding this comment.
We need to remember the index we automatically pick for them so that it stays as they iterate.
dlockhart
force-pushed
the
dlockhart/iterators
branch
from
9be7ca4
to
b729d4c
Compare
Haha I know... they're our "tier 2" chevrons but could maybe use some slimming eh. |
|
Ok I've switched to an upscaled version of our tier1 chevrons instead, which are slimmer: I'm sure Jeff will want to tweak these anyway, so don't want to spend too much time on them. |
Haha yeah I wasn't too worried about it for that reason, but they do look much better! |
|
🎉 This PR is included in version 0.20.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ghost
added
the
You can now iterate between test files or tests within files. The "Home" button is now a breadcrumb on the left, and I made a few other minor stylistic tweaks.